Re: [PATCH] nodeindexscan with reorder memory leak

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Aliaksandr Kalenik <akalenik(at)kontur(dot)io>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] nodeindexscan with reorder memory leak
Date: 2022-01-30 16:02:55
Message-ID: 219144.1643558575@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Aliaksandr Kalenik <akalenik(at)kontur(dot)io> writes:
> The leak is only noticeable when index scan with reorder happens as part of
> subquery plan which is explained by the fact that heap tuples cloned in
> reorderqueue_push are not freed during flush of reorder queue in
> ExecReScanIndex.

Hmm ... I see from the code coverage report[1] that that part of
ExecReScanIndexScan isn't even reached by our existing regression
tests. Seems bad :-(

regards, tom lane

[1] https://coverage.postgresql.org/src/backend/executor/nodeIndexscan.c.gcov.html#577

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-01-30 16:24:35 Re: [PATCH] nodeindexscan with reorder memory leak
Previous Message Magnus Hagander 2022-01-30 15:51:12 Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests