Re: Change copyObject() to use typeof_unqual

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>
Cc: "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Change copyObject() to use typeof_unqual
Date: 2026-03-15 22:13:30
Message-ID: 2191112.1773612810@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl> writes:
> If not, then I'm starting to think that actually checking support for
> this feature for CLANG is probably easier to understand (and less
> fragile) than combining all of these tricks together. Attached is a
> patch to do so.

+1 for concept, but don't you need to fix meson.build too?

>> And alternative is that
>> we decide that we don't want to support this combination, meaning that
>> we would effectively require that clang is approximately as-old-or-newer
>> than gcc.

> Given that Tom seems to have reproduced this on Fedora 40, it sounds
> like we should fix it.

Yeah. Given Fedora's development cycle, it is a certainty that they
shipped gcc and clang versions no more than a couple months different
in age. So even if we wanted to adopt the restriction Peter suggests,
there are not-very-old systems on which it fails.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-03-15 22:16:56 Re: Report bytes and transactions actually sent downtream
Previous Message Tom Lane 2026-03-15 22:06:33 Re: Save a few bytes per CatCTup