Christoph Berg <cb(at)df7cb(dot)de> writes:
> a fellow Debian Developer found a minor glitch in
> src/timezone/localtime.c, where binary search is used. Now I don't
> think there is an actual problem (unless there's > 2^30 timezones),
> but it would at least make sense to mark the code as okayish so that
> people running code scanners won't stumble over the issue again.
> The attached patch added comments to address this.
This is totally silly. The timecnt couldn't be anywhere near INT_MAX (in
fact, it is not allowed to exceed TZ_MAX_TIMES, which is currently just
1200). And there are bunches of other instances of similar code in PG;
shall we put equally wishy-washy comments on them all?
regards, tom lane