Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS
Date: 2014-11-13 22:21:52
Message-ID: 21764.1415917312@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> writes:
> In the same query there is another bug introduced by commit 491c029
> that add Row-Level Security Policies. Current master code has a broken
> pg_dumpall when trying to dump from a backend lower than 8.1.

Actually, I think that code is not just under-tested but poorly thought
out. It will dump ALL roles from a pre-9.5 database with NOBYPASSRLS;
even superusers. I would think that existing superusers ought to be
assumed to have the BYPASSRLS property, no? (This assumes that the
property means anything at all for superusers, which maybe it doesn't;
but if so we probably ought to be forcing it true for superusers to
avoid confusion.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-11-13 22:38:53 Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS
Previous Message Michael Paquier 2014-11-13 22:18:18 Re: Inconsistencies in documentation of row-level locking