Re: Replacing TAP test planning with done_testing()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Replacing TAP test planning with done_testing()
Date: 2022-02-11 20:22:41
Message-ID: 2172514.1644610961@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-02-11 21:04:53 +0100, Daniel Gustafsson wrote:
>> I opted out of backpatching for now, to solicit more comments on that. It's
>> not a bugfix, but it's also not affecting the compiled bits that we ship, so I
>> think there's a case to be made both for and against a backpatch. Looking at
>> the oldest branch we support, it seems we've done roughly 25 changes to the
>> test plans in REL_10_STABLE over the years, so it's neither insignificant nor
>> an everyday activity. Personally I don't have strong opinions, what do others
>> think?

> +1 on backpatching. Backpatching tests now is less likely to cause conflicts,
> but more likely to fail during tests.

If you've got the energy to do it, +1 for backpatching. I agree
with Michael's opinion that doing so will probably save us
future annoyance.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-02-11 20:25:49 Re: support for MERGE
Previous Message Andres Freund 2022-02-11 20:16:22 Re: Replacing TAP test planning with done_testing()