Re: BUG #12106: pg_dump does not resolve circular dependency

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #12106: pg_dump does not resolve circular dependency
Date: 2014-11-30 17:54:37
Message-ID: 21684.1417370077@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> Tom Lane-2 wrote
>> Unless you can demonstrate a credible use-case for this, I don't think
>> it's worth adding complexity to pg_dump for.

> Assuming: "Even worse, pg_dump returns 0 as the exit code, even though
> the dump is not usable. It merely issues a warning on output." is
> confirmed I would assume that it would need to be fixed.

"Not usable" is hyperbole. The actual effect would be that the particular
function would fail to restore, but the rest of it would be fine.

I should note that it's not like we've never seen any other cases of
pg_dump failing to deal with circular dependencies. Issuing a warning
and pushing on is *way* better than refusing the dump entirely.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrew Dunstan 2014-11-30 20:37:35 Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON
Previous Message David G Johnston 2014-11-30 17:38:51 Re: BUG #12106: pg_dump does not resolve circular dependency