| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, David Rowley <drowley(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_dump, ATTACH, and independently restorable child partitions |
| Date: | 2020-12-04 17:13:05 |
| Message-ID: | 2168110.1607101985@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> [ v4-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch ]
The cfbot is being picky about this:
3218pg_dump.c: In function ‘dumpTableAttach’:
3219pg_dump.c:15600:42: error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
3220 if (attachinfo->partitionTbl->dobj.dump & DUMP_COMPONENT_DEFINITION == 0)
3221 ^
3222cc1: all warnings being treated as errors
which if I've got the precedence straight is indeed a bug.
Personally I'd probably write
if (!(attachinfo->partitionTbl->dobj.dump & DUMP_COMPONENT_DEFINITION))
as it seems like a boolean test to me.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2020-12-04 17:14:50 | Re: Logical archiving |
| Previous Message | Tom Lane | 2020-12-04 17:05:16 | Re: [PATCH] Covering SPGiST index |