| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: pg_autovacuum integration patch |
| Date: | 2004-06-16 14:01:11 |
| Message-ID: | 21589.1087394471@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> I also noticed:
> ! elog(ERROR, "pg_autovacuum: GUC variable stats_row_level
> must be enabled.");
> ! elog(ERROR, " Please fix the problems and try
> again.");
> If you use the ereport() call instead of elog, you can set the second
> one as a HINT. Since it's really the same error, I don't think you want
> multiple errors logged...
Even more to the point, control will never *reach* the second elog().
Matthew clearly needs to spend more time studying the backend error
message reporting mechanism. There is some documentation here:
http://developer.postgresql.org/docs/postgres/error-message-reporting.html
and the backend code is certainly chock-full of examples.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthew T. O'Connor | 2004-06-16 14:04:37 | Re: pg_autovacuum integration patch |
| Previous Message | Claudio Natoli | 2004-06-16 13:48:51 | pg_ctl service integration for WIN32 |