Re: Let's start using setenv()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Let's start using setenv()
Date: 2020-12-29 16:45:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Since the cfbot seems happy with v1, here's a v2 that runs around
and converts all putenv() uses to setenv(). In some places there's
no notational savings, but it seems to me that standardizing
on just one way to do it is beneficial.

I'm not sure if there would be any value in revising win32env.c to
treat setenv, rather than putenv, as the primary use-case (and
switching to some corresponding Windows call instead of _putenv).
Perhaps some Windows hacker would be interested in considering that.
For myself, I'm happy with this version as it stands.

regards, tom lane

Attachment Content-Type Size
support-using-setenv-2.patch text/x-diff 28.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2020-12-29 17:48:49 Re: [HACKERS] Custom compression methods
Previous Message Tom Lane 2020-12-29 15:20:43 Re: Weird failure in explain.out with OpenBSD