| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GCC warning in back branches |
| Date: | 2021-02-15 01:41:25 |
| Message-ID: | 2151315.1613353285@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Feb 15, 2021 at 02:15:51PM +1300, Thomas Munro wrote:
>> I propose the attached.
> We usually don't bother much about compilation warnings in stable
> branches as long as they are not real bugs, and these are the oldest
> stable ones. So why here? I would have patched the top of the
> function if it were me, btw.
If somebody were running a buildfarm member with recent gcc
and -Werror, we'd pretty much have to fix it.
I'd say the real policy is that we don't worry about
uninitialized-variable warnings from old compiler versions,
on the theory that they're probably compiler shortcomings.
But I'd be inclined to fix anything from a current gcc version.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-02-15 02:10:50 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Previous Message | Michael Paquier | 2021-02-15 01:34:58 | Re: GCC warning in back branches |