Placement for a /port sort of include file?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Placement for a /port sort of include file?
Date: 2008-05-14 17:02:06
Message-ID: 21474.1210784526@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Since the function-call-statistics patch is going to need the
"instr_time" stuff that's currently in src/include/executor/instrument.h,
I was looking at splitting that out into its own include file. My first
thought about where to put instr_time.h was under src/include/port/,
since it's basically a portability abstraction. But all the files that
are in there right now are platform-specific, so that doesn't seem quite
right. The precedent of rusagestub.h, getopt_long.h, and a few others
is to just drop it into src/include/ but that seems a bit ugly too.
Any thoughts on the matter?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-05-14 17:06:37 Re: Placement for a /port sort of include file?
Previous Message Tom Lane 2008-05-14 16:45:49 Re: What to do with inline warnings?