| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Thread-unsafe coding in ecpg |
| Date: | 2019-01-26 14:57:10 |
| Message-ID: | 21440.1548514630@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Meskes <meskes(at)postgresql(dot)org> writes:
> I wonder if it would be better to make the test cases use the proper
> whenever command instead. That would give us a slightly better
> functionality testing I'd say.
I like having a hard limit on the number of loop iterations;
that should ensure that the test terminates no matter how confused
ecpglib is.
But certainly we could have more of the tests using "whenever"
as the intended method of getting out of the loop.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Finnerty | 2019-01-26 15:26:25 | Re: Use zero for nullness estimates of system attributes |
| Previous Message | Amit Kapila | 2019-01-26 13:14:30 | Re: WIP: Avoid creation of the free space map for small tables |