| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, akapila(at)postgresql(dot)org |
| Subject: | Re: Dead code in logical decoding of speculative insertions |
| Date: | 2026-03-06 09:53:38 |
| Message-ID: | 21434.1772790818@localhost |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Thu, Mar 5, 2026 at 2:59 PM Antonin Houska <ah(at)cybertec(dot)at> wrote:
> >
> > Since commit 4daa140a2f50 adds the INTERNAL_SPEC_ABORT change, I think it's no
> > longer necessary to care about "pending speculations" at the time we receive
> > the next INTERNAL_SPEC_INSERT change.
> >
>
> Right, I also think so. Did you find it via code review or some other way?
Yes, I noticed that via code review, while investigating a crash:
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-03-06 10:27:59 | RE: [PATCH] Support automatic sequence replication |
| Previous Message | jian he | 2026-03-06 09:38:30 | Re: Emitting JSON to file using COPY TO |