Re: [pgsql-hackers-win32] snprintf causes regression tests to fail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nicolai Tufar <ntufar(at)gmail(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Date: 2005-03-01 22:45:31
Message-ID: 2139.1109717131@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Nicolai Tufar <ntufar(at)gmail(dot)com> writes:
> Amazingly enough HAVE_LONG_LONG_INT_64 is
> defined when compilation comes to src/port/snprintf.c
> but the result is still wrong. I looked into configure.in
> but the check for HAVE_LONG_LONG_INT_64 is too
> complicated for me to understand. Bruce, could you
> take a look at this? I am 90% sure it is an issue with
> some configure definitions.

Just out of curiosity, do either HAVE_INT64 or HAVE_UINT64 get set
in pg_config.h? The observed symptoms would be explained if typedef
int64 were ending up as "long" rather than "long long". Looking at
the #ifdef nest in include/c.h, there are a couple of ways that could
happen, including importing a definition from system header files.

If this were happening, it would presumably break all int8 math not
only snprintf, so I'm not sure it's the story. As far as I've seen,
no one has actually posted the regression diffs seen in this failure,
so most of us are in the dark about the details of the problem.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-01 22:57:46 Re: [HACKERS] snprintf causes regression tests to fail
Previous Message Nicolai Tufar 2005-03-01 22:26:37 Re: [pgsql-hackers-win32] snprintf causes regression

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-01 22:57:46 Re: [HACKERS] snprintf causes regression tests to fail
Previous Message Nicolai Tufar 2005-03-01 22:26:37 Re: [pgsql-hackers-win32] snprintf causes regression

Browse pgsql-patches by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-01 23:09:41 Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Previous Message Mark Wong 2005-03-01 21:53:10 Re: [PATCHES] WAL: O_DIRECT and multipage-writer (+ memory leak)