Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared
Date: 2009-12-28 18:45:58
Message-ID: 21381.1262025958@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> Log Message:
> -----------
> Add PGDLLIMPORT for binary_upgrade global variables so shared object
> libraries can access them.

This change is useless, and contrary to our coding standards elsewhere.
You need PGDLLIMPORT on the externs seen by the loadable module. We
don't put it on the actual variable definitions.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2009-12-28 18:49:05 pgsql: Remove PGDLLIMPORT used for binary upgrade; must be on the
Previous Message Bruce Momjian 2009-12-28 18:39:03 pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared