| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Dimitrios Apostolou <jimis(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: [PING] fallocate() causes btrfs to never compress postgresql files |
| Date: | 2026-02-06 22:19:42 |
| Message-ID: | 2136960.1770416382@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Sat, Feb 7, 2026 at 9:31 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Perhaps, but since we're getting pretty hard up against the release
>> freeze deadline, I think the thing to do for today is just to update
>> .abi-compliance-history. We know that way works.
> So it seems I need to do the attached for 18, and the same again for
> 17 and 16. Look about right?
Right.
> I peeked at the libabigail man page, and I don't see any discussion of
> incomplete types, but it looks like OPAQUE_TYPE_LABEL might be a way
> to tell it about this. If that works, wouldn't it be better than
> doing this forever? Where would that be configured?
It looks like that is something you write in a suppression file.
I think it might be too strong for our purposes though: looks like
it blocks *any* complaints related to that type. That'd be
problematic, especially if you can't suppress on just
"struct config_generic[]" without affecting "struct config_generic".
On the whole I think a bit of research and testing would be needed
to go that way. Not to mention a buildfarm client change to get
the abidw calls to pick up the suppression files.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-02-06 22:27:22 | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Previous Message | Nazir Bilal Yavuz | 2026-02-06 22:19:16 | Re: Speed up COPY FROM text/CSV parsing using SIMD |