Re: pg_hba_file_settings view patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_hba_file_settings view patch
Date: 2017-01-30 23:04:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> writes:
> On Mon, Jan 30, 2017 at 5:18 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>> #define USER_AUTH_LAST uaPeer
>> StaticAssertStmt(lengthof(UserAuthName) == USER_AUTH_LAST + 1,
>> "UserAuthName must include all user authentication names");

> Thanks for the review. Added the static assert statement.

This isn't exactly bulletproof, since somebody could add another enum
value and forget to update the macro. Still, it's better than nothing.
I tried to make it a shade more idiot-proof by putting the #define
physically inside the enum list --- you'd have to really have blinders
on to not notice it there. (Not that people haven't made equally silly
mistakes :-(.)

Pushed with that adjustment. Thanks for working on this!

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Glukhov 2017-01-30 23:07:43 [PATCH] kNN for SP-GiST
Previous Message Tom Lane 2017-01-30 22:24:31 Re: Query fails when SRFs are part of FROM clause (Commit id: 69f4b9c85f)