Re: Extensions support for pg_dump, patch v27

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions support for pg_dump, patch v27
Date: 2011-02-08 17:10:24
Message-ID: 21253.1297185024@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> Hm, no, that logic is the same as before no?

> Well I had

> if (!control->relocatable && control->schema != NULL)

> And you have

> + else if (control->schema != NULL)

Yeah, I deleted that relocatable test because it's redundant:
control->schema cannot be set for a relocatable extension,
cf the test in read_extension_control_file.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2011-02-08 17:10:33 Re: Range Types
Previous Message Dimitri Fontaine 2011-02-08 17:09:12 Re: Extensions versus pg_upgrade