| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] hs_standby_disallowed test fix |
| Date: | 2020-05-12 03:05:22 |
| Message-ID: | 2116f5f9-24b6-2750-7698-f887182c5991@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/05/12 8:03, Michail Nikolaev wrote:
> Hello.
>
> There is a recent commit about changes in way read-only commands are
> prevented to be executed [1].
>
> It seems like hs_standby_disallowed test is broken now.
>
> So, a simple patch to fix the test is attached.
Thanks for the report and patch! LGTM.
I just wonder why standbycheck regression test doesn't run by default
in buildfarm. Which caused us not to notice this issue long time. Maybe
because it's difficult to set up hot-standby environment in the
regression test? If so, we might need to merge standbycheck test into
TAP tests for recovery.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-05-12 03:06:00 | Re: PG 13 release notes, first draft |
| Previous Message | Tatsuro Yamada | 2020-05-12 03:00:14 | Re: PG 13 release notes, first draft |