| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Add "format" target to make and ninja to run pgindent and pgperltidy |
| Date: | 2025-12-31 16:13:44 |
| Message-ID: | 21126879-f3ae-4924-b8e0-d7701ca0ac0f@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-12-31 We 10:54 AM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> On 2025-12-31 We 10:26 AM, Tom Lane wrote:
>>> On the substance of the patch: I wonder whether we could make things
>>> more reliable by using git metadata to figure out which .h and .c
>>> files to point pgindent at.
>> I guess what you're wanting is a test to see if the file is in git or a
>> generated file? That doesn't really arise for me as I always do vpath
>> builds, so generated files are always elsewhere.
> Right. But if we're trying to make this easy, we need to make
> the automation work for all three use-cases (in-tree makefiles,
> vpath makefiles, meson). I was just wondering if relying on
> git would simplify getting the same results in all three.
>
>
I think we could use
git ls-files -t $file
or similar.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-12-31 17:04:41 | Re: Can we remove support for standard_conforming_strings = off yet? |
| Previous Message | Andrew Dunstan | 2025-12-31 16:02:36 | Re: Can we remove support for standard_conforming_strings = off yet? |