Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Got you thinking about what? I'd welcome any comments you have.
> I wondered if it should just return char *. If we want to have this
> functionality as its own fmgr-blessed function, shouldn't it return
> text instead of cstring?
If we expose it at fmgr level it should definitely not return cstring.
However, I wasn't foreseeing doing that --- does the submitted patch
expose it?
regards, tom lane