Re: Supporting CSV format log files

From: Chuck McDevitt <cmcdevitt(at)greenplum(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Supporting CSV format log files
Date: 2009-06-06 21:49:47
Message-ID: 2106D8DC89010842BABA5CD03FEA4061CA55CD5E@EXVMBX018-10.exch018.msoutlookonline.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers


> -----Original Message-----
> From: Dave Page [mailto:dpage(at)pgadmin(dot)org]
> Sent: Saturday, June 06, 2009 2:29 PM
> To: Chuck McDevitt
> Cc: pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] Supporting CSV format log files
>
> On Fri, Jun 5, 2009 at 8:03 PM, Chuck McDevitt<cmcdevitt(at)greenplum(dot)com>
> wrote:
> > To extend this to support PostgreSQL 8.4 CSV format log files, I
> think we need to do a couple of things:
> >
> > First, the pg_logdir_ls function from the admin pack would need to be
> updated to look for .log or .csv files, not just .log.
>
> The deadline for submitting changes like that in PostgreSQL 8.4 was
> November!
>
> > Then we would need to recognize that we are reading a file with
> extension .csv, and handle it the way I do in the patch for GPDB
> (rather than being based on GetIsGreenplum()).
> >
> > Finally, we'd just need to figure out what each field being logged by
> PostgreSQL 8.4 is, and update the code so that it understands that as
> well as the GPDB fields.
>
> That'll have to wait for the next cycle.
>
> FYI, PostgreSQL and pgAdmin will go to RC1 on Thursday. The intention
> is to build the GA release on 25/26 June, for release on the 29th.

Yes, supporting PG CSV logs can certainly wait till next release cycle.

But I do need the patch I submitted to be committed, as otherwise the frmStatus display is broken for GPDB, and I'd certainly not want pgAdmin to come out in a form that is broken when using with GPDB.

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2009-06-06 22:07:26 Re: Supporting CSV format log files
Previous Message Dave Page 2009-06-06 21:29:26 Re: Supporting CSV format log files