From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: SQL-standard function body |
Date: | 2020-07-10 17:24:21 |
Message-ID: | 2106877.1594401861@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Wed, Jul 1, 2020 at 5:49 AM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> - More test coverage is needed. Surprisingly, there wasn't actually any
>> test AFAICT that just creates and SQL function and runs it. Most of
>> that code is tested incidentally, but there is very little or no
>> targeted testing of this functionality.
> FYI cfbot showed a sign of some kind of error_context_stack corruption
> while running "DROP TABLE functest3 CASCADE;".
BTW, it occurs to me after answering bug #16534 that
contrib/earthdistance's SQL functions would be great candidates for this
new syntax. Binding their references at creation time is really exactly
what we want.
I still feel that we can't just replace the existing implementation,
though, as that would kill too many use-cases where late binding is
helpful.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2020-07-10 17:26:27 | Re: Default setting for enable_hashagg_disk |
Previous Message | Alvaro Herrera | 2020-07-10 17:16:40 | Re: expose parallel leader in CSV and log_line_prefix |