Location for window function API definitions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Cc: "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com>
Subject: Location for window function API definitions
Date: 2008-12-22 04:02:27
Message-ID: 21038.1229918547@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The window functions patch defines some API functions and macros for
window functions. These are currently defined in executor/nodeWindow.h,
but that seems to me like a fairly inappropriate location. The executor
main body, which would be the normal consumer of that include file, has
no interest in the API functions; and conversely the window-plan-node
functions that are defined for the executor are not things for window
functions to call. So I think the API definitions need to go someplace
else.

The only existing file that seems appropriate is include/funcapi.h, but
that also contains a lot of stuff that wouldn't be useful to a typical
window function.

If we invent a new include file for the purpose, possible names might be
include/windowapi.h
include/executor/windowapi.h
or something else.

Comments?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-12-22 04:06:09 Re: about truncate
Previous Message David Fetter 2008-12-22 03:42:38 Re: about truncate