Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Cc: peter_e(at)gmx(dot)net, seva(at)sevasoft(dot)kiev(dot)ua, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal
Date: 2001-09-04 02:17:29
Message-ID: 21006.999569849@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> But if the config switch was removed, Tcls prior 8.1 would not be
> supported at all, no?

No, Peter wasn't proposing removing #if's from the code. His thought
is that the #if's should be conditional only on Tcl version --- if you
have a Tcl version that does UTF, then you get the translation code.

Of course, there are some issues here about compiling against a
different set of Tcl headers than you later run against, but I think
you could get burnt by that anyway.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tatsuo Ishii 2001-09-04 02:34:45 Re: Patch for pl/tcl Tcl_ExternalToUtf and
Previous Message Bruce Momjian 2001-09-04 02:14:50 Re: Bytea/Base64 encoders for libpq - interested?