| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ignore invalid indexes in pg_dump |
| Date: | 2013-03-26 21:47:30 |
| Message-ID: | 21002.1364334450@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On top of checking indisvalid, I think that some additional checks on
> indislive and indisready are also necessary.
Those are not necessary, as an index that is marked indisvalid should
certainly also have those flags set. If it didn't require making two
new version distinctions in getIndexes(), I'd be okay with the extra
checks; but as-is I think the maintenance pain this would add greatly
outweighs any likely value.
I've committed this in the simpler form that just adds indisvalid
checks to the appropriate version cases.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2013-03-26 21:48:27 | Re: spoonbill vs. -HEAD |
| Previous Message | Kevin Grittner | 2013-03-26 21:46:11 | Re: Drastic performance loss in assert-enabled build in HEAD |