| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | useless argument of ATAddForeignKeyConstraint |
| Date: | 2019-02-14 09:47:42 |
| Message-ID: | 209c99fe-b9a2-94f4-cd68-a8304186a09e@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While reviewing the foreign keys referencing partitioned tables patch, I
noticed that the parentConstr argument of ATAddForeignConstraint is
rendered useless by the following commit:
commit 0325d7a5957ba39a0dce90835ab54a08ab8bf762
Author: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Date: Fri Jan 18 14:49:40 2019 -0300
Fix creation of duplicate foreign keys on partitions
Above commit added another function specialized for recursively adding a
given foreign key constraint to partitions, so ATAddForeignConstraint is
no longer called recursively.
Maybe remove that argument in HEAD ? Attached a patch.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| remove-useless-arg-ATAddForeignKeyConstraint.patch | text/plain | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2019-02-14 09:57:40 | Re: pg_basebackup ignores the existing data directory permissions |
| Previous Message | Etsuro Fujita | 2019-02-14 09:44:40 | Re: Problems with plan estimates in postgres_fdw |