Re: Fix typos for v12

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix typos for v12
Date: 2019-05-25 15:06:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> I have taken one pass over it and all fixes seem to be correct and got
> introduced in v12. I will re-verify them once again and then commit
> your patch if I don't found any problem. In the meantime, if anyone
> else wants to look at it, that would be great.

FWIW, I'd counsel against applying the changes in imath.h/.c, as that
is not our code, and unnecessary variations from upstream will just
make it harder to track upstream. The rest of this looks fine.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-05-25 15:48:47 Re: POC: converting Lists into arrays
Previous Message Amit Kapila 2019-05-25 13:37:52 Re: Fix typos for v12