Re: [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Date: 2008-03-27 21:11:37
Message-ID: 2092.1206652297@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-performance

Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> On Sunday 16 March 2008 22:18, Tom Lane wrote:
>> Fix TransactionIdIsCurrentTransactionId() to use binary search instead of
>> linear search when checking child-transaction XIDs.

> Are there any plans to backpatch this into REL8_3_STABLE?

No.

> It looks like I am
> hitting a pretty serious performance regression on 8.3 with a stored
> procedure that grabs a pretty big recordset, and loops through doing
> insert....update on unique failures. The procedure get progressivly slower
> the more records involved... and dbx shows me stuck in
> TransactionIdIsCurrentTransactionId().

If you can convince me it's a regression I might reconsider, but I
rather doubt that 8.2 was better,

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-03-28 00:21:56 pgsql: Support statement-level ON TRUNCATE triggers.
Previous Message Robert Treat 2008-03-27 20:56:45 Re: [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search

Browse pgsql-hackers by date

  From Date Subject
Next Message Keaton Adams 2008-03-27 21:17:21 PostgreSQL Replication with read-only access to standby DB
Previous Message Robert Treat 2008-03-27 20:56:45 Re: [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search

Browse pgsql-performance by date

  From Date Subject
Next Message Robert Treat 2008-03-28 05:51:54 Re: [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Previous Message Robert Treat 2008-03-27 20:56:45 Re: [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search