Re: Warnings in CVS build

Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
> Some warnings in current CVS build in BSD4.3:

> xact.c:590: warning: implicit declaration of function `select'

Where is select() declared in your system headers? Evidently we're
missing a #include, but I dunno which.

> dynloader.c:85: warning: unused variable `buf'

Assuming that this is freebsd, I've suppressed that warning.

> /usr/include/grp.h:58: warning: parameter names (without types) in function
> declaration

This one probably ought to be directed to the BSD maintainers.

> pgc.c:1244: warning: label `find_rule' defined but not used
> pgc.c:3091: warning: `yy_flex_realloc' defined but not used
> pl_scan.c:1004: warning: label `find_rule' defined but not used
> pl_scan.c:2295: warning: `yy_flex_realloc' defined but not used

As Thomas pointed out, we can't do much about these without control
of the flex sources. They've irritated me for a long time, since
they're the only build warnings I get. It's interesting though that
our other flex files don't provoke these warnings. Perhaps the
problem only occurs if the flex source file uses yylineno?

> odbcapi.c:140: warning: no previous prototype for `SQLDataSources'

I think Hiroshi fixed this already.

> pg_restore.c:166: warning: implicit declaration of function `getopt'

This one's yours to fix ...

> Also some odd tsort messages. eg.

These are just tsort being noisy. I'm not sure why we bother with
tsorting library member files any more anyway --- do any supported
platforms actually need it?

regards, tom lane