| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] pgsql: Fix compiler warnings on 64-bit boxes: |
| Date: | 2006-09-06 16:55:07 |
| Message-ID: | 20830.1157561707@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
>> ereport(...errmsg("trouble at offset " UINT64_FORMAT, bigintvar));
> One more solution: add format code %D to expand_fmt_string() which should be
> expanded to usual %d on 32-bit architecture and to UINT64_FORMAT on 64-bit.
Not very workable unless you can figure out how to teach gcc what it means...
else we lose compiler checking that the corresponding argument matches,
which'd be even more important than usual with a machine-dependent
format code.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User H-saito | 2006-09-06 17:45:05 | npgsql - Npgsql: Ooops,sorry.. |
| Previous Message | Teodor Sigaev | 2006-09-06 16:41:24 | Re: [HACKERS] pgsql: Fix compiler warnings on 64-bit |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2006-09-06 17:01:21 | Re: ECPG/OpenBSD buildfarm failures, take I |
| Previous Message | Stephen Frost | 2006-09-06 16:50:20 | Multi-valued user-defined types |