Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, marius(dot)timmer(at)uni-muenster(dot)de, arne(dot)scheffer(at)uni-muenster(dot)de
Subject: Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)
Date: 2018-03-02 20:02:53
Message-ID: 20816.1520020973@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de> writes:
> Andres Freund wrote on 2018-03-02:
>> and I'd checked that 1.5 already exists. But you just renamed the file,
>> presumably because it's essentially rewriting the whole file? I'm not
>> sure I'm a big fan of doing so, because that makes testing the upgrade
>> path more work.

> You're right about 1.5 already existing. I wasn't sure about the versioning policy for extensions and seeing as version 1.5 only changed a few grants I quasi reused 1.5 for my intentions.

Nope, that's totally wrong. You can get away with that if we've not
already shipped a 1.5 release --- but we did ship it in v10, so that
version is frozen now. You need to make your changes in a 1.5--1.6
upgrade file. Otherwise there's no clean path for existing installations
to upgrade to the new version.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-03-02 20:05:29 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Robert Haas 2018-03-02 20:01:41 Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly