Re: pgsql: ALTER TABLE: skip FK validation when it's safe to do so

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: ALTER TABLE: skip FK validation when it's safe to do so
Date: 2012-02-27 22:49:08
Message-ID: 20799.1330382948@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Committer's note: catalog version bumped due to change of the Constraint
> node. I can't actually find any way to have such a node in a stored
> rule, but given that we have "out" support for them, better be safe.

FYI, the easy way to determine this is to see if the node type has
readfuncs.c support. If not, it's not usable in stored rules. There
are a lot of node types that have outfuncs support for debugging
purposes, so looking at outfuncs alone can be misleading.

In this particular case I believe the catversion bump was unnecessary,
though of course it doesn't hurt.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2012-02-28 04:15:59 pgsql: psql: when tab-completing, use quotes on file names that need th
Previous Message Alvaro Herrera 2012-02-27 22:16:01 pgsql: ALTER TABLE: skip FK validation when it's safe to do so