From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Rudolf Gavlas <r(dot)stu3(dot)1(at)googlemail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] get_home_path: use HOME |
Date: | 2016-09-20 16:35:24 |
Message-ID: | 20753.1474389324@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Rudolf Gavlas <r(dot)stu3(dot)1(at)googlemail(dot)com> writes:
> The usage of HOME environment variable (if set) is IMO the right,
> standard and faster way to get_home_path().
Can you provide some evidence for that claim? I can believe "faster"
but the rest sounds like wishful thinking.
> I work in an environment, where servers are administered by people
> with different user names and identical uid (0).
I think what you have there is an incredibly badly-designed system that
can be expected to break outside software (eg, Postgres). If we take
this patch, what's to stop someone from complaining that we broke *their*
badly-designed system that abuses the HOME variable? I'm pretty hesitant
to touch code that's worked the same way for a decade or two on such a
basis.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2016-09-20 16:45:12 | Re: pageinspect: Hash index support |
Previous Message | Robert Haas | 2016-09-20 16:32:56 | Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied” |