Re: outfuncs.c utility statement support

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: outfuncs.c utility statement support
Date: 2017-06-14 03:49:36
Message-ID: 2071d3c8-3520-4f02-d1a6-bceb933f8779@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/13/17 11:25, Peter Eisentraut wrote:
> Running with --debug-print-parse=on, executing
>
> create table test1 (a int, b text);
>
> gives output that is truncated somewhere in the middle (possibly a null
> byte)

So this seems to be a pretty basic bug. Some node fields of type char
may be zero, and so printing them as a zero byte just truncates the
whole output string. This could be fixed by printing chars like strings
with the full escaping mechanism. See attached patch.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Fix-output-of-char-node-fields.patch text/plain 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-06-14 03:50:24 Re: A bug in mapping attributes in ATExecAttachPartition()
Previous Message Michael Paquier 2017-06-14 03:46:21 Re: Detection of IPC::Run presence in SSL TAP tests