|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|To:||Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>|
|Cc:||Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Karl Lehenbauer <karl(at)flightaware(dot)com>|
|Subject:||Re: Add support for SRF and returning composites to pl/tcl|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> writes:
> On 1/6/17 2:45 PM, Tom Lane wrote:
>> While I was checking the patch to verify that it didn't change any
>> behavior, I noticed that it did, and there's a pre-existing bug here:
>> pltcl_build_tuple_result is applying utf_e2u to the Tcl_GetString results,
>> but surely that should be utf_u2e instead. Fortunately we haven't shipped
>> this code yet.
> For this patch lets just fix that (see attached).
I already fixed it in HEAD.
> Moving forward, I think it'd be good to improve this...
Yeah, it's pretty ugly, but I'm not sure what would be a better design.
regards, tom lane
|Next Message||Pavel Stehule||2017-01-08 05:44:42||Re: merging some features from plpgsql2 project|
|Previous Message||Pavel Stehule||2017-01-08 05:26:01||Re: merging some features from plpgsql2 project|