From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ALTER TABLE .. ALTER COLUMN .. ERROR: attribute .. has wrong type |
Date: | 2017-01-06 20:08:05 |
Message-ID: | 20691.1483733285@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Alvaro Herrera wrote:
>> Here's a first attempt at fixing this. It makes the test pass, but I
>> have the feeling that more complex ones might need more work.
> Here's another one with three main differences:
Hmm. The bespoke code for constructing the attno map bothers me;
surely there is existing code that does that? If not, it'd still
make more sense to factor it out, I think, because there will be
other needs for it in future.
Otherwise, this seems sound in terms of fixing the observed problem,
but what are the implications for event triggers exactly? Does a
trigger see only the original expression, or only the modified expression,
or ???
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-01-06 20:17:10 | Re: Increase pltcl test coverage |
Previous Message | Thomas Munro | 2017-01-06 20:02:26 | Re: WIP: [[Parallel] Shared] Hash |