Re: pgsql: Clean up overly paranoid checks in mac8.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Clean up overly paranoid checks in mac8.c
Date: 2017-03-16 03:38:16
Message-ID: 20683.1489635496@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>> Clean up overly paranoid checks in mac8.c

> termite thinks this wasn't quite right.

On looking at it a bit more closely, I think you've forgotten that
"char" is signed on some platforms and unsigned on others. I'd
suggest putting explicit casts to unsigned char into these tests.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2017-03-16 03:39:49 Re: pgsql: Clean up overly paranoid checks in mac8.c
Previous Message Stephen Frost 2017-03-16 03:36:56 Re: pgsql: Clean up overly paranoid checks in mac8.c