Re: nonempty default log_line_prefix (was [COMMITTERS] pgsql: Simplify handling of the timezone GUC)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: nonempty default log_line_prefix (was [COMMITTERS] pgsql: Simplify handling of the timezone GUC)
Date: 2011-09-10 02:42:10
Message-ID: 20673.1315622530@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Tom Lane's message of vie sep 09 18:59:45 -0300 2011:
>> Simplify handling of the timezone GUC by making initdb choose the default.

> Hmm, I was hoping that this might open the door for setting a nonempty
> default log_line_prefix, but apparently not :-( Seems
> setup_formatted_start_time is still expecting that GUC initialization
> would be called before we do anything with it. Pity ...

I think it actually would work now, you'd just have to accept that any
log messages that come out during GUC initialization might appear in GMT.
I didn't really experiment with that angle of it --- feel free.

But having said that, I'm not sure that there's a consensus for changing
the default log_line_prefix.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-09-10 02:57:51 pgsql: Try to un-break MSVC build.
Previous Message Alvaro Herrera 2011-09-10 01:31:53 nonempty default log_line_prefix (was [COMMITTERS] pgsql: Simplify handling of the timezone GUC)

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2011-09-10 03:28:16 Re: Large C files
Previous Message Alvaro Herrera 2011-09-10 01:31:53 nonempty default log_line_prefix (was [COMMITTERS] pgsql: Simplify handling of the timezone GUC)