David Geier <geidav(dot)pg(at)gmail(dot)com> writes:
> What about, while not being strictly necessary for PostgreSQL itself,
> also adding such casts to simplehash.h so that it can be used in code
> where -Wc++-compat is enabled?
Seems reasonable, so done (I fixed one additional spot you missed).
The bigger picture here is that we do actually endeavor to keep
(most of) our headers C++ clean, but our tool cpluspluscheck misses
these problems because it doesn't try to use these macros.
I wonder whether there is a way to do better.
regards, tom lane