Re: pgsql: Enable parallel SELECT for "INSERT INTO ... SELECT ...".

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <akapila(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Enable parallel SELECT for "INSERT INTO ... SELECT ...".
Date: 2021-03-10 03:37:35
Message-ID: 2060179.1615347455@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Amit Kapila <akapila(at)postgresql(dot)org> writes:
> Enable parallel SELECT for "INSERT INTO ... SELECT ...".

skink (valgrind) is unhappy:

creating configuration files ... ok
running bootstrap script ... ok
performing post-bootstrap initialization ... ==4085668== VALGRINDERROR-BEGIN
==4085668== Conditional jump or move depends on uninitialised value(s)
==4085668== at 0x4AEB77: max_parallel_hazard_walker (clauses.c:700)
==4085668== by 0x445287: expression_tree_walker (nodeFuncs.c:2188)
==4085668== by 0x4AEBB8: max_parallel_hazard_walker (clauses.c:860)
==4085668== by 0x4B045E: is_parallel_safe (clauses.c:637)
==4085668== by 0x4985D0: grouping_planner (planner.c:2070)
==4085668== by 0x49AE4F: subquery_planner (planner.c:1024)
==4085668== by 0x49B4F5: standard_planner (planner.c:404)
==4085668== by 0x49BAD2: planner (planner.c:273)
==4085668== by 0x5818BE: pg_plan_query (postgres.c:809)
==4085668== by 0x581977: pg_plan_queries (postgres.c:900)
==4085668== by 0x581E70: exec_simple_query (postgres.c:1092)
==4085668== by 0x583F7A: PostgresMain (postgres.c:4327)
==4085668== Uninitialised value was created by a stack allocation
==4085668== at 0x4B0363: is_parallel_safe (clauses.c:599)
==4085668==
==4085668== VALGRINDERROR-END

There are a few other commits that skink hasn't seen before, but given
the apparent connection to parallel planning, none of the others look
like plausible candidates to explain this.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2021-03-10 04:16:35 Re: pgsql: Enable parallel SELECT for "INSERT INTO ... SELECT ...".
Previous Message Amit Kapila 2021-03-10 02:17:54 pgsql: Enable parallel SELECT for "INSERT INTO ... SELECT ...".

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2021-03-10 03:42:55 Re: Removing vacuum_cleanup_index_scale_factor
Previous Message Julien Rouhaud 2021-03-10 03:35:53 Re: Add some tests for pg_stat_statements compatibility verification under contrib