Re: Fix bug of clearing of waitStart in ProcWakeup()

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: ji xu <thanksgreed(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix bug of clearing of waitStart in ProcWakeup()
Date: 2026-02-24 22:03:14
Message-ID: 2058F900-0706-4B46-A398-54FDABFD29F7@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Feb 24, 2026, at 23:41, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Feb 24, 2026 at 4:31 PM ji xu <thanksgreed(at)gmail(dot)com> wrote:
>>
>>
>> Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> 于2026年2月24日周二 14:29写道:
>>>
>>> Since this function is clearly operating on the parameter proc, the only statement that touches MyProc looks suspicious. It should reset proc->waitStart, not MyProc->waitStart.
>>>
>>> As written, it will incorrectly clear the caller’s waitStart instead of the awakened backend’s, potentially leaving a stale waitStart value in the target PGPROC.
>
> Thanks for the report!
>

I just realized that I forgot to attach the patch file. Anyway, that’s just a one-line change.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v1-0001-Fix-bug-of-clearing-of-waitStart-in-ProcWakeup.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message SATYANARAYANA NARLAPURAM 2026-02-24 22:08:37 synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication
Previous Message Peter Eisentraut 2026-02-24 21:54:52 Re: change default default_toast_compression to lz4?