| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cache lookup error when using jsonb, json_build_object and a WITH clause |
| Date: | 2014-05-09 15:42:49 |
| Message-ID: | 20582.1399650169@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
>> Anybody see other problems to fix here?
> Yea.
> 5)
> if (val_type > FirstNormalObjectId)
> isn't fundamentally incorrect but imo shouldn't be replaced by something
> like !IsCatalogType() (akin to IsCatalogRelation). At least if we decide
> that hunk is safe from other POVs - I am not actually 100% sure yet.
I didn't particularly like that either. The test is off-by-one, for
one thing (a type created right at OID wraparound could have
FirstNormalObjectId). However, it seems reasonable to avoid fruitless
syscache searches for builtin types, and I'm not seeing a lot of point
to wrapping this test in some macro.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-05-09 15:50:11 | Re: Sending out a request for more buildfarm animals? |
| Previous Message | Tom Lane | 2014-05-09 15:35:41 | Re: Cache lookup error when using jsonb, json_build_object and a WITH clause |