From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Extensions vs PGXS' MODULE_PATHNAME handling |
Date: | 2011-02-13 17:56:05 |
Message-ID: | 20582.1297619765@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> I'm hesitant to have any substitutions that happen unconditionally,
>> but we could add a control parameter like
>> module_pathname = '$libdir/hstore'
>> and then things would be pretty clean.
> Ok. Maybe the simpler would be to make the current control variable a
> static backend variable so that EXT_CONTROL(module_pathname) is easy to
> find out from anywhere (I see you got rid of some direct usage of static
> variables with recordDependencyOnCurrentExtension() already).
I think it's better to keep it working as a textual substitution.
That poses the least risk of breaking scripts that work today ---
who's to say that somebody might not be relying on the substitution
happening someplace else than CREATE FUNCTION's shlib string?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2011-02-13 18:39:23 | Re: Debian readline/libedit breakage |
Previous Message | Steve Singer | 2011-02-13 17:49:14 | Re: pl/python custom exceptions for SPI |