Re: Fix dumping pre-10 DBs by pg_dump10 if table "name" exists

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix dumping pre-10 DBs by pg_dump10 if table "name" exists
Date: 2017-10-31 15:00:38
Message-ID: 20547.1509462038@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> writes:
> Recently my colleagues found a bug.

> - "SELECT 'bigint'::name AS sequence_type, "
> + "SELECT 'bigint'::pg_catalog.name AS sequence_type,

Good catch, but I think we could simplify this by just omitting the cast
altogether:

- "SELECT 'bigint'::name AS sequence_type, "
+ "SELECT 'bigint' AS sequence_type,

pg_dump doesn't particularly care whether the column comes back marked
as 'name' or 'text' or 'unknown'.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Zakirov 2017-10-31 15:05:16 Re: [PATCH] Generic type subscripting
Previous Message Tom Lane 2017-10-31 14:56:07 Re: Add some const decorations to prototypes