Re: like/ilike improvements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: andrew(at)supernews(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: like/ilike improvements
Date: 2007-05-23 14:41:09
Message-ID: 20530.1179931269@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> We should only be able to get out of step from the "%_" case, I believe,
> so we should only need to do the first-byte test in that case (which is
> in a different code path from the normal "_" case. Does that seem right?

At least put Assert(IsFirstByte()) in the main path.

I'm a bit suspicious of the separate-path business anyway. Will it do
the right thing with say "%%%_" ?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-05-23 14:52:44 Re: like/ilike improvements
Previous Message NikhilS 2007-05-23 14:39:20 Re: CREATE TABLE LIKE INCLUDING INDEXES support

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-05-23 14:52:44 Re: like/ilike improvements
Previous Message NikhilS 2007-05-23 14:39:20 Re: CREATE TABLE LIKE INCLUDING INDEXES support