Re: partitioned tables and contrib/sepgsql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Joe Conway <mail(at)joeconway(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mike Palmiotto <mike(dot)palmiotto(at)crunchydata(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: partitioned tables and contrib/sepgsql
Date: 2017-04-05 16:26:25
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> GCC generally doesn't warn about macro redefinitions, if both
> definitions are equivalent.

But they're *not* equivalent. c.h has

#define true ((bool) 1)

whereas so far as I can see the <stdbool.h> definition is just

#define true 1

And if you put those two definitions together you will get a warning.
The lack of one with c.h + <stdbool.h> means somebody is cheating.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-04-05 16:26:49 Re: Functions Immutable but not parallel safe?
Previous Message Tom Lane 2017-04-05 16:23:02 Re: PG_GETARG_GISTENTRY?