| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: enable fallthrough warnings on clang |
| Date: | 2026-04-07 14:35:27 |
| Message-ID: | 2042830.1775572527@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 06.04.26 23:31, Tom Lane wrote:
>> BF member ayu is failing said test:
>> ...
>> I don't know if it's worth catering to this extremely old
>> clang version ...
> But AFAICT, clang 5 and older are completely broken in this regard,
> because they react to the presence of [[clang::fallthrough]] with a
> syntax error ("error: expected expression"). Not even clang's own
> example code[0] works.
Hah, so we'd make it worse not better by adding
[[clang::fallthrough]]. Let's leave well enough alone then.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-04-07 14:36:09 | Re: Add errdetail() with PID and UID about source of termination signal |
| Previous Message | SATYANARAYANA NARLAPURAM | 2026-04-07 14:32:40 | Re: SQL:2011 Application Time Update & Delete |