Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pailloncy Jean-Gerard <jg(at)rilk(dot)com>
Cc: pgsql-performance(at)postgresql(dot)org
Subject: Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE
Date: 2004-12-23 22:44:34
Message-ID: 2035.1103841874@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-performance

Pailloncy Jean-Gerard <jg(at)rilk(dot)com> writes:
> I think I have a test case for 7.4.2

Try the attached patch.

It looked to me like there were some smaller leaks going on during COPY
and CREATE INDEX, which I will look into later --- but this seems to be
the problem for VACUUM FULL.

regards, tom lane

Index: vacuum.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/commands/vacuum.c,v
retrieving revision 1.263
diff -c -r1.263 vacuum.c
*** vacuum.c 2 Oct 2003 23:19:44 -0000 1.263
--- vacuum.c 23 Dec 2004 22:37:57 -0000
***************
*** 2041,2046 ****
--- 2041,2047 ----
ExecStoreTuple(&newtup, slot, InvalidBuffer, false);
ExecInsertIndexTuples(slot, &(newtup.t_self),
estate, true);
+ ResetPerTupleExprContext(estate);
}

WriteBuffer(cur_buffer);
***************
*** 2174,2179 ****
--- 2175,2181 ----
{
ExecStoreTuple(&newtup, slot, InvalidBuffer, false);
ExecInsertIndexTuples(slot, &(newtup.t_self), estate, true);
+ ResetPerTupleExprContext(estate);
}
} /* walk along page */

In response to

Browse pgsql-performance by date

  From Date Subject
Next Message Pierre-Frédéric Caillaud 2004-12-24 01:47:40 Re: LIMIT causes SEQSCAN in subselect
Previous Message William Yu 2004-12-23 21:45:57 Re: Some Performance Advice Needed