Re: OS timezone files support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: OS timezone files support
Date: 2007-03-22 18:23:03
Message-ID: 20334.1174587783@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> Tom Lane wrote:
>> I certainly don't see the point of the implementation as you have it
>> --- it adds a great deal of unnecessary infrastructure compared to just
>> installing a symlink at share/postgresql/timezone.

> The point of my solution is that all packagers who interested in use
> only configure switch instead of playing with link integration. In this
> case, Packager also must cleanup build-in timezones after make install.
> This is not only about add one line into spec file.

No, it's two lines (rm -rf, ln -s). It'll take many more lines than
that to do it in the Postgres configure/build system, even using the
simpler symlink approach. And quite aside from the code addition, what
of documentation? How much text will it take to make clear what this
switch is good for and when it's safe to use?

I just don't see the value of supporting this option in our
configuration infrastructure. Anyone who is competent to determine
whether it's a safe thing to use is more than competent to alter the
installation that way for themselves.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Zdenek Kotala 2007-03-22 18:35:44 Re: OS timezone files support
Previous Message Zdenek Kotala 2007-03-22 18:13:24 Re: OS timezone files support